On 2023/11/08 11:23, lijiang wrote:
> On Mon, Nov 6, 2023 at 1:33 PM Shijie Huang <
> shijie@amperemail.onmicrosoft.com> wrote:
>> 在 2023/11/6 13:16, HAGIO KAZUHITO(萩尾 一仁) 写道:
>>> On 2023/11/06 14:04, HAGIO KAZUHITO(萩尾 一仁) wrote:
>>>> On 2023/11/03 18:45, Shijie Huang wrote:
>>>>
>>>>>> +summary_inode_page(ulong page)
>>>>>> +{
>>>>>> +       int node;
>>>>>> +
>>>>>> +       if (!is_page_ptr(page, NULL))
>>>>>> +               error(FATAL, "Invalid inode page(0x%lx)\n", page);
>>>> I don't remember the detail of xarray, but my cacheutils extension
>>>> module also checks this without any error, in its callback function [1].
>>>> So how about implementing like this?
>>> in the first place, dump_inode_page() for "files -p" also checks this
>>> first without any error.  I think we can follow this.
>>>
>>> https://github.com/crash-utility/crash/blob/master/memory.c#L6891
>>
>> okay. no problem.
>>
>>
> Seems not enough.
>
> crash> files -n ffff8ea84c130938
>       INODE        NRPAGES
> ffff8ea84c130938    62527
>
> files: do_xarray: callback operation failed: entry: 1  item: 0
> crash>
>
> That is why I would suggest using the 'error(FATAL,...)' instead of the
> 'return':
>
> https://lists.crash-utility.osci.io/archives/list/devel@lists.crash-utility.osci.io/thread/7ZBSSZ7SKP73EZYAJEZYRLWCG2N5J4KQ/
>
> Or ignore this output? Any thoughts?

Then "files -p" option also emits the same error?

     INODE        NRPAGES
ffff8ea84c130938    62527

      PAGE        PHYSICAL      MAPPING       INDEX CNT FLAGS
fffff5168860d000 218340000 ffff8ea84c130ab0        0  5 17ffffc0012076 referenced,uptodate,lru,active,workingset,private,head
files: do_xarray: callback operation failed: entry: 1  item: 0

crash> files -n  ffff8ea84c130938
     INODE        NRPAGES
ffff8ea84c130938    62527

files: do_xarray: callback operation failed: entry: 1  item: 0

 

Is that /proc/kcore?  What is the kernel version?

crash> sys
      KERNEL: /lib/modules/6.5.0-rc1+/build/vmlinux
    DUMPFILE: /proc/kcore
        CPUS: 24
        DATE: Wed Nov  8 04:07:03 EST 2023
      UPTIME: 63 days, 02:41:27
LOAD AVERAGE: 0.00, 0.00, 0.00
       TASKS: 411
    NODENAME: xxx-xxx
     RELEASE: 6.5.0-rc1+
     VERSION: #2 SMP PREEMPT_DYNAMIC Mon Jul 10 22:48:15 EDT 2023
     MACHINE: x86_64  (2394 Mhz)
      MEMORY: 15.9 GB
crash>

Thanks,
Kazu