On 2023/11/30 0:31, Tao Liu wrote:
>> And I did not see the debuginfo again(only one time):
>> gdb_get_line_number 7101
>>
>> Did I miss anything else?
Is there no case where sal.symtab == NULL after expansion?
I don't think of, but e.g. a wrong address is requested.
personally I'm ok with the current patch for fail-safe, quite a simple one.
also reverting is troublesome... this is my fault though.
No worries, Kazu. If any risks are found in the future, we can try to fix them.
Let's leave it there for now. Just an idea, no other specific concerns.
Thanks
Lianbo
Thanks,
Kazu
>>
> I cannot reproduce the performance issue, not sure why...
>
> The problem I encountered previously, is the first find_pc_line()
> always return sal.symtab==NULL, so if
> "!objfile_has_full_symbols(objfile)" check removed,
> expand_all_symtabs() will be called multiple times, which will
> decrease the overall performance. So I drafted the patch by using a
> objfile->all_symtabs_expanded flag instead. And I have tried to debug
> into find_pc_line() to find out the reason, however I failed.
>
> Since I cannot reproduce the performance issue, then I think we can
> use the removing "!objfile_has_full_symbols(objfile)" check, it is
> more simple.
>
> Thanks,
> Tao Liu
>