Hi Lijiang & kuan-ying,

On Mon, Aug 5, 2024 at 6:33 PM lijiang <lijiang@redhat.com> wrote:
>
> On Mon, Aug 5, 2024 at 9:31 AM <devel-request@lists.crash-utility.osci.io> wrote:
>>
>> Date: Sun, 04 Aug 2024 05:46:17 -0000
>> From: kuan-ying.lee@canonical.com
>> Subject: [Crash-utility] Re: [PATCH] arm64: Introduction of support
>>         for 16K page with 3-level table support
>> To: devel@lists.crash-utility.osci.io
>> Message-ID: <20240804054617.17290.54860@lists.crash-utility.osci.io>
>> Content-Type: text/plain; charset="utf-8"
>>
>> Hi Lijiang and Tao,
>>
>> Thanks for taking look at this patch.
>>
>> I use kernel-6.10 to build arm64 kernel.
>> I modify arch/arm64/configs/defconfig with the following diff.
>>
>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
>> index 2c7bf4da0b80..f981095a4440 100644
>> --- a/arch/arm64/configs/defconfig
>> +++ b/arch/arm64/configs/defconfig
>> @@ -1682,12 +1682,10 @@ CONFIG_CMA_SIZE_MBYTES=32
>>  CONFIG_PRINTK_TIME=y
>>  CONFIG_DEBUG_KERNEL=y
>>  CONFIG_DEBUG_INFO_DWARF_TOOLCHAIN_DEFAULT=y
>> -CONFIG_DEBUG_INFO_REDUCED=y
>>  CONFIG_MAGIC_SYSRQ=y
>>  CONFIG_DEBUG_FS=y
>>  # CONFIG_SCHED_DEBUG is not set
>>  # CONFIG_DEBUG_PREEMPT is not set
>> -# CONFIG_FTRACE is not set
>>  CONFIG_CORESIGHT=m
>>  CONFIG_CORESIGHT_LINK_AND_SINK_TMC=m
>>  CONFIG_CORESIGHT_CATU=m
>> @@ -1697,3 +1695,7 @@ CONFIG_CORESIGHT_STM=m
>>  CONFIG_CORESIGHT_CPU_DEBUG=m
>>  CONFIG_CORESIGHT_CTI=m
>>  CONFIG_MEMTEST=y
>> +CONFIG_GDB_SCRIPTS=y
>> +CONFIG_STACKTRACE=y
>> +CONFIG_ARM64_VA_BITS_47=y
>> +CONFIG_ARM64_16K_PAGES=y
>>
>
> Thank you for sharing this, Kuan-Ying.
>
> I tried to build the latest upstream kernel on another machine(with the va_bits 47 and 16k_pages configs), it works.
>
> The code changes are fine to me, and I do not see any new issues in my tests.
>
> Just one thing, there is an indentation issue in the arm64_vtop_3level_16k(), but I can help to correct it(when merging).
>
> For the patch: Ack

Also the patch passed my testing, LGTM, ack.

Thanks,
Tao Liu

>
>
> Thanks
> Lianbo
>
>> I can boot up with qemu-system-aarch64 and after booting up, I run the "echo c > /proc/sysrq-trigger" in qemu to produce the
>> vmcore.
>>
>> After I get vmcore, I can use crash-tool to debug vmcore and vmlinux.
>>
>> Thank you,
>> Kuan-Ying Lee
>
> --
> Crash-utility mailing list -- devel@lists.crash-utility.osci.io
> To unsubscribe send an email to devel-leave@lists.crash-utility.osci.io
> https://${domain_name}/admin/lists/devel.lists.crash-utility.osci.io/
> Contribution Guidelines: https://github.com/crash-utility/crash/wiki