Date: Wed, 2 Apr 2025 15:22:41 +1300
From: Tao Liu <ltao@redhat.com>
Subject: [Crash-utility] Re: [PATCH] RISCV64: Add more system
        properties to the 'mach' command
To: Austin Kim <austindh.kim@gmail.com>
Cc: devel@lists.crash-utility.osci.io
Message-ID:
        <CAO7dBbWhevdJ8bBBnLp265-PuNjwVgq_SMyP+2ojnO0X4jEUpg@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"

Hi Austin,

On Tue, Apr 1, 2025 at 3:07 PM Austin Kim <austindh.kim@gmail.com> wrote:
>
> Currently, 'mach' command displays only basic system properties for
> RISC-V-based vmcores. This commit enhances the mach command by adding
> additional system details, including virtual memory addresses, IRQ stacks,
> and overflow stacks.
>
> (before)
> crash> mach
>                 MACHINE TYPE: riscv64
>                  MEMORY SIZE: 4 GB
>                         CPUS: 4
>              PROCESSOR SPEED: (unknown)
>                           HZ: 100
>                    PAGE SIZE: 4096
>            KERNEL STACK SIZE: 16384
>
> (after)
> crash> mach
>                 MACHINE TYPE: riscv64
>                  MEMORY SIZE: 4 GB
>                         CPUS: 4
>              PROCESSOR SPEED: (unknown)
>                           HZ: 100
>                    PAGE SIZE: 4096
> KERNEL VIRTUAL BASE: ffffffd800000000
> KERNEL MODULES BASE: ffffffff01d08000
> KERNEL VMALLOC BASE: ffffffc800000000
> KERNEL VMEMMAP BASE: ffffffc700000000
>            KERNEL STACK SIZE: 16384
>      IRQ STACK SIZE: 16384
>          IRQ STACKS:
>               CPU 0: ffffffc800000000
>               CPU 1: ffffffc800008000
>               CPU 2: ffffffc800010000
>               CPU 3: ffffffc800018000
> OVERFLOW STACK SIZE: 4096
>     OVERFLOW STACKS:
>               CPU 0: ffffffd8fc7433c0
>               CPU 1: ffffffd8fc75f3c0
>               CPU 2: ffffffd8fc77b3c0
>               CPU 3: ffffffd8fc7973c0
>
> Signed-off-by: Austin Kim <austindh.kim@gmail.com>

The patch LGTM, so ack.

Thanks,
Tao Liu