On Mon, Mar 6, 2023 at 4:20 PM lijiang <lijiang@redhat.com> wrote:
On Mon, Mar 6, 2023 at 3:09 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab@nec.com> wrote:
On 2023/03/02 18:08, lijiang wrote:

> This looks good to me with the above modifications. So: Ack.

Thanks, but I found a build failure on a RHEL7 machine:

   CC       malloc/scratch_buffer_grow.o
In file included from ./libc-config.h:159:0,
                  from malloc/scratch_buffer_grow.c:20:
./cdefs.h:562:31: fatal error: bits/long-double.h: No such file or directory
  # include <bits/long-double.h>
                                ^
compilation terminated.
...


Good findings, Kazu. I didn't test it on RHEL7 and earlier.
 
and found that the following gnulib patch fixes the above, so
I added the libc-config.h hunk to the attached.

This looks good.
 

https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=afeeb21058d1

Is this ok too?  It's helpful if you could test again.

I will test it tomorrow, because I can not log in to the beaker machine today.

For v3, the test is ok to me, let's go with this, Kazu.

Thanks.
Lianbo


Thanks.
Lianbo