On Tue, Oct 7, 2025 at 7:36 PM Mikhail Zaslonko <zaslonko@linux.ibm.com> wrote:
Hi Tao,

On 10/7/2025 1:11 AM, Tao Liu wrote:
> On Tue, Sep 30, 2025 at 8:18 PM lijiang <lijiang@redhat.com> wrote:
>>
>> On Tue, Sep 30, 2025 at 3:01 PM Mikhail Zaslonko <zaslonko@linux.ibm.com> wrote:
>>>
>>> Hello,
>>>
>>> On 9/30/2025 4:53 AM, lijiang wrote:
>>>> On Tue, Sep 30, 2025 at 2:18 AM Mikhail Zaslonko <zaslonko@linux.ibm.com>
>>>> wrote:
>>>>
>>>>> Hi Lianbo,
>>>>>
>>>>> It seems we have a problem printing disassembly blocks in the log after
>>>>> this patch (at least on s390).
>>>>> See number of empty lines printed below.
>>>>>
>>>>
>>>> Can you try it with the following two patches?
>>>> [1]
>>>> https://www.mail-archive.com/devel@lists.crash-utility.osci.io/msg01621.html
>>> This patch is present on crash master, doesnt affect the issue.
>>>> [2]
>>>> https://www.mail-archive.com/devel@lists.crash-utility.osci.io/msg01636.html
>>>>
>>> This one helps indeed! At least I do not se the blanks lines in my scenario.
>>> BUT, if I use 'log -R' the blank lines are back again!
>>
>>
>> Thanks for the information, Mikhail.
>> Let me see how to debug this(although I can not reproduce it on s390x).
>
> I didn't reproduce the issue on my s390x machine either, maybe sharing
> the vmcore to us can help.

I'm not sure I'm allowed to send this data outside.

Sorry for the late reply because of China holiday.
 
If you can share your test case(or steps), that will help me to reproduce the current issue.

Anyway I will check it in detail.

I think the problem takes place for the logs printed with pr_cont() by the
kernel (e.g. show_code() of arch/s390/kernel/dis.c for printing disassembly as
in my sample).

Thanks for the information.

Lianbo