Thanks for the review, Tao.
On Thu, Mar 20, 2025 at 1:16 PM Tao Liu <ltao@redhat.com> wrote:
Hi lianbo,

Thanks for the improvements, for the series, LGTM, ack.

Applied(with a minor change):
[1] https://github.com/crash-utility/crash/commit/bc1fc6ac218cdca8d0259832e0d2f338640d3477
[2] https://github.com/crash-utility/crash/commit/3115791c6894802b5f590c7a97fcc6516ae22a9e
[3] https://github.com/crash-utility/crash/commit/1248bfa806020abbbde5f52e9257889698580b57
[4] https://github.com/crash-utility/crash/commit/a312f58feb05bf86c78d2a10ee051be8db26c6bd

Thanks
Lianbo
 

Thanks,
Tao Liu


On Mon, Mar 17, 2025 at 10:03 PM Lianbo Jiang <lijiang@redhat.com> wrote:
>
> The patchset will add cross compilation and CI build
> for crash-utility, includes four patches:
> [1] [PATCH 1/4] sparc64: fix build failure
> [2] [PATCH 2/4] gdb:disable building gdbserver in crash-utility
>     This will speed up crash building and save time, also avoid
>     some compilation issues, the [3] and [4] will benefit from
>     this one.
> [3] [PATCH 3/4] Add cross compilation support
>     E.g: cross build crash-utility for aarch64 on X86_64
>     make CROSS_COMPILE=aarch64-linux-gnu- -j`nproc`
>     or
>     make CROSS_COMPILE=aarch64-linux-gnu- -j`nproc` warn
>
>     Note: there are still some limitations for cross
>     compilation because some dependency libs that are not
>     cross-compiled, for example: snappy, lzo, zstd
> [4] [PATCH 4/4] Add ci-build.yml
>     Add a CI build and enable it on multiple arches, which can
>     check for compilation issues and also reduce some maintaince
>     workload.
>
> Please refer to the result of CI build:
> https://github.com/lian-bo/crash/actions/runs/13895225118
>
> v1->v2:
> [PATCH 0-3]: No changes, just rebased on gdb-16.2
> [PATCH 4]: The gdb-16.2 has the dependency of gmp and mpfr libs, so need
> to cross compile them before cross compile crash-utility.
>
> Lianbo Jiang (3):
>   sparc64: fix build failure
>   gdb:disable building gdbserver in crash-utility
>   Add cross compilation support
>
> lian-bo (1):
>   Add ci-build.yml
>
>  .github/workflows/ci-build.yml | 93 ++++++++++++++++++++++++++++++++++
>  Makefile                       | 50 +++++++++++++++++-
>  README                         |  5 ++
>  configure.c                    |  6 +++
>  defs.h                         |  2 +-
>  gdb-16.2.patch                 | 12 +++++
>  help.c                         |  5 ++
>  7 files changed, 170 insertions(+), 3 deletions(-)
>  create mode 100644 .github/workflows/ci-build.yml
>
> --
> 2.47.1
>