Re: [Crash-utility] [PATCHv8 0/4] crash-utility/arm64: memory layout bug fixes
On Mon, Jun 28, 2021 at 06:32:34AM +0000, HAGIO KAZUHITO(萩尾 一仁) wrote:
-----Original Message-----
> This series fix the bug caused by arm64 kernel memory layout changes
The patchset was very hard to review for me, maybe because of its fixing
order? The 2/4 patch uses PAGE_OFFSET but it is changed by 4/4 finally,
I'm not sure what is fixed and why it can be fixed by 2/4. so it might
be easier to review if it fixes them in order like:
1) fix for PAGE_OFFSET issue on 5.4 and later
2) fix for physvirt_offset loss on 5.10 and later.
But you don't have to rewrite it, just an idea.
This series originate from two independent bugs. Since they are closely related
to arm64 memory layout changes, finally I organize them in a batch.
Sorry for the confusion. I will re-order them.
And as you know, I cannot test arm64 crash, please let me know about
things I missed.
This series can play with vmcore and kcore on RHEL9 (kernel v5.12, v5.13-rc).
Without it, the crash-utility fails. For compatibility, RHEL-8.5 can work
fine with this series (kernel v4.18)
Thanks,
Pingfan