Re: [Crash-utility] [PATCH] Add ELF core dump support for s390x
----- "Michael Holzheu" <holzheu(a)linux.vnet.ibm.com> wrote:
Dave,
On Mon, 2010-02-15 at 16:56 -0500, Dave Anderson wrote:
> ----- "Michael Holzheu" <holzheu(a)linux.vnet.ibm.com> wrote:
> > Sorry, I did not read your note carefully. If you want to do that then
> > my current implementation is wrong. The problem is that now I expect ELF
> > note structures and will always do. It is not possible to support
> > multiple dump formats with my current approach.
>
> Sure it's possible. In the (unlikely) case s390x ever needs to support
anything
> else, the first int argument can be made a uniquely-identifiable
"command"
> or some such.
First of all: It is VERY likely that we will support a new dump format
in the near future. Believe me.
I was talking about the ELF format specifically, and even if the ELF format needs
another tweak for s390x, it can be handled easily.
Second, how should that work? The callback has an integer and a void
pointer. The integer is currently used to specify the CPU number. The
void pointer is used to hold the ELF note information. How the hell can
I code the information for a new dump format. Or am I missing
something?
Make the first command command -- in the unlikely event this feature
would ever be required -- start with a #define of NR_CPUS+1, or with the
high bits encoded, or whatever.
Dave