Re: [Crash-utility] [PATCH] Add support for 'foreign' page sizes in kdump dumps

Unlike Robin's patch, your patch to read_dump_header() drops this error check: if (sizeof(*header) + sizeof(void *) * header->nr_cpus > block_size || header->nr_cpus <= 0) { error(INFO, "%s: invalid nr_cpus value: %d\n", DISKDUMP_VALID() ? "diskdump" : "compressed kdump", header->nr_cpus); goto err; } I didn't write this, but it seems to be a valid check. Did you determine that it's impossible even though crash does allow 4096 cpus for ia64? Or is it a bogus to begin with?