Re: [Crash-utility] [PATCH] ARM SMP
----- "Mika Westerberg" <ext-mika.1.westerberg(a)nokia.com> wrote:
Hi Per,
On Thu, Sep 30, 2010 at 11:19:28AM +0200, ext Per Fransson wrote:
>
> This patch is an attempt to get the ball rolling on SMP support for ARM.
I noticed that this patch is line-wrapped so it doesn't apply cleanly (or is it
our brilliant exchange server which mangled that).
No, I ran into the same problem...
Also, I now note that this piece below is incorrect. GETBUF() buffers are
transitory, because they all get freed as soon as free_all_bufs() is called
next: (such as in restore_sanity() prior to each command)
+ panic_task_regs =
GETBUF(kt->cpus*sizeof(*panic_task_regs));
- ms->crash_task_regs = &panic_task_regs;
+ ms->crash_task_regs = panic_task_regs;
You'd have to use malloc() for the panic_task_regs assignment.
It looks like the other GETBUF() calls are for temporary buffers.
Dave