Re: [Crash-utility] [PATCH 0/4] sadump, kaslr: fix failure of calculating kaslr_offset due to an sadump format restriction
Hi Hatayama-san,
sorry for the delay.
-----Original Message-----
This patch series fix failure of calculating kaslr_offset due to an
sadump format restriction.
The main part is the 4-th patch. I found some small bugs during this
work and the 2nd and 3rd are to fix them and are also needed for the
4-th patch.
There are a few slight comments, but otherwise the series looks good to me
and easy to review. It was helpful, thanks!
Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
Lianbo, Bhupesh, can we have another ack?
And we'd like to put tags such as Signed-off-by, Reported-by, etc. on commit
log for better tracking if possible. So can I have your signed-off-by tag?
Then I will fix the few things I commented with it and merge. Or if you can
post a v2, it's also ok.
(fyi, I'm going to merge patches in a patchset separately if it's suitable.
usually I won't unite them like Dave had done.)
Thanks,
Kazu
This issue occurs also in makedumpfile, and I have already posted the
corresponding patch for makedumpfile at:
http://lists.infradead.org/pipermail/kexec/2020-July/020852.html
HATAYAMA Daisuke (4):
symbols: Add linux_banner_vmlinux in symbol table
symbols: fix initialization of st->{pti_init,kaiser}_vmlinux
kaslr: cleanup how to set values to the arguments of
calc_kaslr_offset()
kaslr: fix failure of calculating kaslr_offset due to an sadump format
restriction
defs.h | 1 +
kaslr_helper.c | 61 +++++++++++++++++++++++++++++++++++++++++++++-------------
sadump.c | 18 ++++++++++-------
symbols.c | 25 +++++++++++++++++++-----
4 files changed, 80 insertions(+), 25 deletions(-)
--
1.8.3.1