Re: [Crash-utility] [PATCH v2] kmem: Add support to -S option to specify a range of CPU-specific slab data

Thanks for the update.

> + for (i = 0; i < kt->cpus; i++) > + if (NUM_IN_BITMAP(cpus, i) && check_offline_cpu(i)) > + error(INFO, "CPU %d is OFFLINE.\n", i); With the offline hide option, "CPU xx [OFFLINE]" is shown as follows and this error message is not needed. crash> set offline hide offline: hide crash> kmem -S=15 TCP kmem: CPU 15 is OFFLINE. CACHE OBJSIZE ALLOCATED TOTAL SLABS SSIZE NAME ffff916f6798b2c0 2440 17 208 16 32k TCP CPU 15 [OFFLINE] ...

And the other commands do not say anything by default (offline show), it should be the same behavior with them.

So with removing the for block above, (but you don't need to repost) Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com&gt;