On 2023/06/05 12:07, lijiang wrote:
>> -#define ORC_TYPE_CALL 0
>> +#define ORC_TYPE_CALL ((machdep->flags & ORC_6_4) ? 2
> : 0)
>
>> #define ORC_TYPE_REGS 1
>> #define ORC_TYPE_REGS_IRET 2
>> #define UNWIND_HINT_TYPE_SAVE 3
>
> These entries are not used in crash so far, remove them?
> or add a comment like this?
>
> /* The below entries are not used and must be updated if we use them. */
>
>
Agree. And the v2 looks good to me, so: Ack(with the above changes).
BTW: no need to post again, you can apply the v2 with the above changes.
Thank you for the review.
Chose adding the comment and applied.
https://github.com/crash-utility/crash/commit/77d8621876c1c6a3a25b91e464b...
Thanks,
Kazu