Re: [Crash-utility] [PATCH] Fix C99 compatibility issues in embedded copy of GDB

>> I raised the issue of <sys/cdefs.h> syncing here: >> >> Updating <sys/cdefs.h> in glibc and gnulib >> <https://sourceware.org/pipermail/libc-alpha/2023-February/145758.html> Regarding cdefs.h, there's another aspect that I had missed when I wrote the aboce: for future 2.34-based distros (CentOS 9 Stream today, Red Hat Enterprise Linux 9.2 when it comes out), I believe the gnulib/glibc cdefs.h handshake has been fixed with a glibc change: the glibc header now defines the __attribute_nonnull__ macro, which gnulib uses as an indicator that the header is recent enough, so it won't interpose its own version. So hopefully this is going to be more stable in the future, and future such syncs become less necessary.

> True, but there is no plan to update the embedded GDB for now and it > would be better to sync with the upstream code just in case, so I've > updated some hunks like so. Does the attached patch work for you? I can confirm this patch passes build testing with an instrumented compiler that logs C99 compatibility issues.