Re: [Crash-utility] [PATCH] Add -r option to timer
Hello Dave,
Changed according to your suggestions. But need to add some explanation
here.
change 1:
Perhaps there could be a way to pre-verify the addresses with
accessible(), and if the address is bogus, display an error message,
but allow the command to continue on with the other cpus?
Error comes from rb_last() which used to calculate the space for
printing expires.
I fixed rb_last(), adding pre-verify the addresses. But I didn't use
rb_last() any more, for change 2 helps to find the last hrtimer.
change 2:
Maybe you can use hq_open()/hq_enter()/hq_close() on the hrtimer addresses
to prevent this from happening, warn the user when it does, and continue on
with the next cpu?
As you suggested.
change3:
When doing some snap test, I found rb_node's data may be destroyed, so
I also fixed other rbtree manipulation functions to avoid abort of
command.
--
--
Regards
Qiao Nuohan
Attachments:
- 0001-make-rbtree-manipulation-functions-global.patch (text/x-patch — 7.0 KB)
- 0002-hrtimer-add-r-option-to-command-timer.patch (text/x-patch — 16.9 KB)