On Tue, 2006-01-31 at 21:38 +0530, Rachita Kothiyal wrote:
On Tue, Jan 31, 2006 at 09:11:36AM -0500, Dave Anderson wrote:
>
> Thanks for handling this. I haven't looked at this, and correct me
> if I'm wrong, but the kernel (what version exactly?) now has contains
> a _cpu_pda[NR_CPUS] array containing pointers to the actual per-cpu
> x8664_pda structures.
Hi Dave,
This change was introduced 2.6.16-rc1 onwards.
>
> Unless I'm missing something, that simplifies things and should work
> just fine. But I can't test it here other than to verify that it's
> backwards compatible. Can you verify that?
Yes, this is infact more simpler and cleaner. I have incorporated the
changes and regenerated the patch, which I am sending along. I have
also tested it on a 2.6.16-rc1 kernel, and it works fine.
Thanks
Rachita
Hmm.. Lots of duplicated code. I hacked the same thing earlier to make
it work. I incorporated my changes into yours.
Does this look better ?
(BTW, is there a way to combine CPU_PDA_READ() and _CPU_PDA_READ() by
abstracting some of it out ?)
Thanks,
Badari