Re: [Crash-utility] [PATCH 1/2] Fix cpu_slab freelist handling on SLUB
OGAWA Hirofumi <hirofumi(a)mail.parknet.co.jp> writes:
> I'm thinking we should clarify that error message, perhaps by
storing the cpu
> number in si->cpu, and displaying it when si->slab is NULL?
Just a idea for now though (means not tested error path at all), how
about the following?
We know already slab pointer at that point. So, this sets si->slab
temporarily. (and slub_page_objects() just uses slab in argument, not
si->slab).
BTW, if we want much more precise error report, IMO, it would be better
to refactoring first.
E.g. get_freepointer() can be for both of cpu_slab and page freelist.
So, we may want to report which one. But we don't bring cpu_slab
pointer in current code, and no generic function to get cpu_slab pointer.
And I don't know whether some sort of big refactoring is acceptable for
crash project. If it is acceptable, I might be able to help more or
less.
Thanks.
--
OGAWA Hirofumi <hirofumi(a)mail.parknet.co.jp>