> I've rebased the patch and modified the commit log as my
comments above
> and attached. Lianbo, is this OK?
as talked internally, Lianbo had no further comments, so applied it.
https://github.com/crash-utility/crash/commit/eedf12d4758409c3c405f56edf3...
Thank you for applying it, and sorry I couldn't respond and make comments lately.
On the other hand, I found a building issue on Ubuntu 22.04.4 LTS.
CXX x86-low.o
CXXLD gdbserver
/usr/bin/ld: ../gnulib/import/libgnu.a(fcntl.o): relocation R_X86_64_32S against
`.rodata' can not be used when making a PIE object; recompile with -fPIE
/usr/bin/ld: failed to set dynamic section sizes: bad value
collect2: error: ld returned 1 exit status
make[4]: *** [Makefile:355: gdbserver] Error 1
make[3]: *** [Makefile:9673: all-gdbserver] Error 2
make[2]: *** [Makefile:860: all] Error 2
crash build failed
make[1]: *** [Makefile:263: gdb_merge] Error 1
make: *** [Makefile:254: all] Error 2
As suggested by the message, building succeeds when make CFLAGS="-fPIE".
Also, this issue disappears when I revert the commit.
I don't see this issue on RHEL and Fedora environment.
So, I presume -fPIE is needed to build gdb depending on toolset on distributions.
Thanks.
HATAYAMA, Daisuke