Re: [Crash-utility] [PATCH] netdump: Add a helper function to check if registers is available for a given active task in ELF notes
From: Dave Anderson <anderson(a)redhat.com>
Subject: Re: [Crash-utility] [PATCH] netdump: Add a helper function to check if registers
is available for a given active task in ELF notes
Date: Mon, 4 Apr 2011 09:21:11 -0400 (EDT)
OK, so where do we stand here? Should I take your defs.h and
netdump.c
patches as they are? (perhaps with the error() panic/active argument fix)
Or do you want to export "nd" and move some of the changes back into
the gcore module? (if that makes sense)
Well, could you export "nd" by deleating static or by adding
get_netdump_vmcore_data() at next release? It's your choise on
removing a serise of get_arch_regs_from_elf_notes(). Anyway if you
removed them, I would reimplement get_x86_64_regs_from_elf_notes(),
which is only necessary function for me, in gcore extension module
through the exported "nd".
I'm releasing a new version of gcore extension module this week, and
in the version, I'll temporarily deal with the fatal action caused due
to absense of note information for non-panic active tasks in some way.
Thanks.
HATAYAMA, Daisuke