Hi Lianbo,
On 2022/08/22 12:59, lijiang wrote:
Thank you for the update, Kazu.
On Mon, Aug 22, 2022 at 10:59 AM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab(a)nec.com>
wrote:
> "sum" command in coreutils-9.0 (e.g. Fedora 36) started to output a file
> name. As a result, "make" always detects a change of gdb-10.2.patch
> wrongly and re-applies it unnecessarily.
>
> Use standard input to fix it and "md5sum" to improve detection.
>
> Signed-off-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
> ---
> Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile b/Makefile
> index 162c2ba..79aef17 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -272,7 +272,7 @@ rebuild:
> @if [ ! -f ${GDB}/${GDB}.patch ]; then \
> touch ${GDB}/${GDB}.patch; fi
> @if [ -f ${GDB}.patch ] && [ -s ${GDB}.patch ] && \
> - [ "`sum ${GDB}.patch`" != "`sum ${GDB}/${GDB}.patch`"
]; then \
> + [ "`md5sum < ${GDB}.patch`" != "`md5sum <
${GDB}/${GDB}.patch`"
> ]; then \
>
Ack for the V2.
Thanks, applied.
https://github.com/crash-utility/crash/commit/c2743ad474529951ace2b8ec712...
btw, could you review these patches?
[PATCH] Fix gcc-11 compiler warnings on gdb-10.2/gdb/symtab.c
[PATCH] Fix gcc-12 compiler warnings on lkcd_*.c
(hmm, now the list archive [1] returns an error..?)
[1]
https://listman.redhat.com/archives/crash-utility/
Thanks,
Kazu