Re: [Crash-utility] [PATCH 2/2] dis: Report duplicate symbols

----- Original Message ----- > > > ----- Original Message ----- > > Notify the user if there is more than one symbol of the given target. > > > > For example, after this patch: > > > > - The 'dis' command now reports that more than one symbol of "watchdog" > > exists, to allow the user to be more specific > > > > crash> dis watchdog > > duplicate symbols found: watchdog > > ffffffff810e6100 (t) watchdog > > /usr/src/debug/kernel-2.6.32-431.1.2.el6/linux-2.6.32-431.1.2.el6.x86_64/kernel/hung_task.c: > > 199 > > ffffffff810e6990 (t) watchdog > > /usr/src/debug/kernel-2.6.32-431.1.2.el6/linux-2.6.32-431.1.2.el6.x86_64/kernel/watchdog.c: > > 332 > > ffffffff81eb3fc8 (b) watchdog Also, is it worth worrying about non-text symbols like the "(b) watchdog" above? Maybe the patch should ignore symbols whose sp->type is not (t) or (T)?