Hi Dave,
On Tue, 1 Feb 2011 12:10:14 -0500 (EST)
Dave Anderson <anderson(a)redhat.com> wrote:
I renamed the multi-purpose read_dump_file() function to be
read_flattened_format(), and only call it when the dumpfile
is a flat vmcore. For clarification/maintainability, I prefer
to keep the original lseek/read calls in diskdump.c and netdump.c
as they were, mainly because it's not intuitive to have the
traditional netdump, kdump, and diskdump dumpfiles require an
access function that is located in the new makedumpfile.c.
I also felt read_dump_file() was not a good name, but I did not
have a better one.
So all of your fixing is reasonable for maintainability, thanks.
Thanks
Ken'ichi Ohmichi