Re: [Crash-utility] [PATCH] crash/ppc64: Remove redundant PTE checks.

On 2023/06/16 20:55, Likhitha Korrapati wrote: > Patch removes redundant checks for PTE (Page Table Entry) because those > conditions are already covered. > > if (!(pte & _PAGE_PRESENT)) { > ... > return FALSE; > } > > if (!pte) > return FALSE; > > The second pte check is redundant because it holds true only when pte is > 0. if pte is 0 then (!(pte & _PAGE_PRESENT)) is true and it will return > false. so there is no need for one more pte check. > > Signed-off-by: Likhitha Korrapati <likhitha(a)linux.ibm.com&gt; thanks for the cleanup. Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com&gt;