Re: [Crash-utility] [PATCH] Fix kernel version macros for revision numbers over 255

> Do you mean the following changes can not work? > > #define THIS_KERNEL_VERSION ((kt->kernel_version[0] << 16) + \ > (kt->kernel_version[1] << 8) + \ > ((kt->kernel_version[2] > 255) ? 255 : > (kt->kernel_version[2]))) > #define LINUX(x,y,z) (((uint)(x) << 16) + ((uint)(y) << 8) + ((uint)(z) > > 255 ? 255 : (uint)(z))) No, in the current crash, this will work. Because there is no if-conditional that checks a revision value over 255. > if (THIS_KERNEL_VERSION < LINUX(4,14,300)) But yes, when we need to check like this, the above cannot work. For example, THIS_KERNEL_VERSION on 4.14.310 equals to LINUX(4,14,300).

So, my thought is that it would be better to change the shift amounts now for future changes with the small effort, rather than change it again in the future.