Re: [Crash-utility] [PATCH] s390: Fix stack trace code for program checks
Hello Dave,
On Wed, 2011-05-04 at 10:13 -0400, Dave Anderson wrote:
> > I'm not particularly enamored with the use of the
zero-filled
> > "double-number" frame fields -- mainly because it's different
> > than all of the other architectures (even the s390).
> > The other arches just move the asterisk one field to the left if the
> > frame
> > number goes into double figures, keeping the remaining fields
> > lined up:
> >
> > fprintf(fp, "%s#%d [ ...
> > level < 10 ? " " : "",
> >
> > While I try not to interfere with architecture maintainers,
> > is there a particular reason you want to do it that way?
>
> No problem. This is also fine with me. Should I change this or do you
> want to do that?
>
> Michael
I just changed print_frame() to do it. And, sorry -- I didn't mean
to twist your arm... ;-)
It is good to keep the architectures as similar as possible. That's part
of your job :-)
Queued for 5.1.15.
Thanks!
Michael