[Crash-utility] Re: [PATCH] Fix for "bt pid" command not printing enough stack trace

On 1/16/24 16:11, HAGIO KAZUHITO(萩尾 一仁) wrote: > On 2024/01/15 16:58, Lianbo Jiang wrote: > >>> --- a/x86_64.c >>> +++ b/x86_64.c >>> @@ -3342,6 +3342,13 @@ x86_64_print_stack_entry(struct bt_info *bt, >>> FILE >>> *ofp, int level, >>> >>>            bt->call_target = name; >>> >>> +       /* >>> +        * The caller check below does not work correctly for some >>> +        * kernels, so skip it if ORC unwidner is available. >>> +        */ >>> +       if (machdep->flags & ORC) >>> +               return result; >>> + >>>            if (is_direct_call_target(bt)) { >>>                    if (CRASHDEBUG(2)) >>>                            fprintf(ofp, "< enable BT_CHECK_CALLER for >>> %s >\n", >>> >>> Could I have the output of "bt 493113" after "set debug 2" with this? >>> (An attached text file is better for logs.) >> Sure.  Please check the crash_bt_493113.txt. > Thanks, the call trace looks correct. Thank you for the confirmation, Kazu. > I've updated the patch at my end, is the attached ok for you? This change looks good to me in this case.  But the reporter is: Crystal Wood <crwood(a)redhat.com&gt;, not me. :-)