Re: [Crash-utility] Make note information human readable when help -D
On 12/18/2014 05:07 AM, Dave Anderson wrote:
OK thanks -- although further testing showed that the patch needed a
bit more work
in netdump.c to prevent calling display_ELF_note() if:
(1) the architecture is not x86 or x86-64
(2) the note type is not NT_PRSTATUS or QEMU, because it would also erroneously pass
pointers to other note types such as NT_PRPSINFO and NT_TASKSTRUCT.
Queued for crash-7.1.0:
https://github.com/crash-utility/crash/commit/e36a1eb28b30c12deb72ffc5157...
Hello Dave,
I found something is missing in the committed patch. In dump_Elf64_Nhdr, qemu note of X86
is not available to call display_ELF_note. The process is like below:
if (BITS32() && type == NT_PRSTATUS)
display_ELF_note
else
if (machine_type("X86_64"))
display_ELF_note
And about the fix, please check the attachment.
--
Regards
Qiao Nuohan
Attachments:
- 0001-qemu-note.patch (text/x-patch — 1.0 KB)