Re: [Crash-utility] [PATCH 00/12] Add sadump format support

Tuesday, 13 September 2011

----- Original Message -----
...
 Hello Dave,

 I'm sorry for taking considerably long time. Now I post a patch set
 implementing sadump support for crash utility.

 Applying this patch set, crash utility will be able to recognize
 sadump-related formats on 3 kinds configurations: single partition,
 diskset and media backup file.

 The crash version the patch set can be applied to is 5.1.7.

 Please look at each patch description for detailed explanation. 
Hello Daisuke,

The patch-set looks good, and the changes to the common code are 
nicely segregated.

But let's simplify things.  I'd prefer to avoid all of these constructs:

   if (!(pc->flags & DUMPFILE_TYPES) && !(pc->flags2 & SADUMP))
   	...
   if ((pc->flags & MEMORY_SOURCES) || (pc->flags2 & MEMORY_SOURCES2))
	...

Can you move the REMOTE_DAEMON bit from pc->flags to the next available
pc->flags2 bit, and then change these four references appropriately:

  C symbol: REMOTE_DAEMON

    File   Function             Line
  0 defs.h <global>              145 #define REMOTE_DAEMON (0x200ULL)
  1 defs.h REMOTE                206 #define REMOTE() (pc->flags & REMOTE_DAEMON)
  2 main.c main                  375 pc->flags |= REMOTE_DAEMON;
  3 main.c dump_program_context 1084 if (pc->flags & REMOTE_DAEMON)

Then you can make SADUMP equal to 0x200ULL, and put it in pc->flags,
DUMPFILE_TYPES and MEMORY_SOURCES.  That will signficantly simplify 
the patch-set.

...
 BTW, do you want sadump dumpfiles? I geuss you need them for testing
 samples. 
Definitely -- but please make them as small as possible, and you can
send me the dumpfile-access details privately if you prefer.

Depending upon how quickly you can create an updated patchset, I may defer
this to crash-5.1.9 because I'm just about to release 5.1.8.

Thanks,
  Dave

...
 Makefile | 10 +-
 defs.h | 33 ++
 filesys.c | 2 +-
 kernel.c | 6 +-
 main.c | 49 ++-
 memory.c | 23 +-
 netdump.c | 2 +-
 remote.c | 2 +-
 sadump.c | 1554
 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 sadump.h | 210 +++++++++
 tools.c | 18 +-
 x86.c | 16 +-
 x86_64.c | 39 ++-
 13 files changed, 1929 insertions(+), 35 deletions(-)

 Thanks.
 HATAYAMA, Daisuke

 [Text
 Documents:0001-defs.h-Add-minimum-sadump-related-definitions-and-de.patch]

 [Text Documents:0002-sadump-sadump-core-module.patch]

 [Text
 Documents:0003-x86_64-Set-up-phys_base-on-sadump-dumpfiles.patch]

 [Text Documents:0004-memory-Get-page-size-on-sadump-dumpfiles.patch]

 [Text
 Documents:0005-filesys-Add-sadump-dumpfile-in-supported-dumpfile-ch.patch]

 [Text Documents:0006-main-Add-sadump-dumpfiles-check.patch]

 [Text Documents:0007-Makefile-Add-sadump-dumpfiles-case.patch]

 [Text
 Documents:0008-sadump-Add-sadump-register-collection-processing.patch]

 [Text Documents:0009-bt-Add-sadump-related-processing.patch]

 [Text
 Documents:0010-sadump-kernel-sys-command-displays-multiple-dumpfile.patch]

 [Text Documents:0011-memory-Add-sadump-related-memory-interface.patch]

 [Text
 Documents:0012-sadump-Return-zero-page-to-excluded-page-if-set-zero.patch]

 --
 Crash-utility mailing list
 Crash-utility(a)redhat.com
 https://www.redhat.com/mailman/listinfo/crash-utility 

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Re: [Crash-utility] [PATCH 00/12] Add sadump format support