Re: [Crash-utility] x86_64 limit of 454 cpu's?

I think that it is good to check the format of the header though makedumpfile sets header->nr_cpus of course. So I think that the following code is better. if ((DISDUMP_VALID() && sizeof(*header) + sizeof(void *) * header->nr_cpus > block_size) || header->nr_cpus <= 0) { error(INFO, "%s: invalid nr_cpus value: %d\n", DISKDUMP_VALID() ? "diskdump" : "compressed kdump", header->nr_cpus); goto err; } And, - makedumpfile doesn't use tasks array as Indoh-san said. - I don't think that makedumpfile malfunctions for CPUs more than 454. Thanks, tachibana