Re: [Crash-utility] Cell/B.E. SPU commands extension

Lucio Correia wrote: > Hi, > > I've developed this crash extension to analyze SPU specific data for > Cell/B.E. processor. This extension makes use of some important data > saved by this kernel patch (that is not mainline yet) > http://ozlabs.org/pipermail/cbe-oss-dev/2007-May/001848.html during the > crash dump. > > I would like to check if there is any issue with the code. > Functionally it looks fine. I changed the _init() function to just do an error(INFO, ...) so I could load the extensions, and the only suggestion I can make is purely aesthetic, which would be to make the "help" messages 80 characters or less like the regular commands are. In other words, the "DESCRIPTION" section outputs, and the sentences in in the "spuctx" EXAMPLE section are kind of ugly the way that they run on with no linefeeds. But like I said before, I don't see any issues/problems with the code -- pretty nifty extension... Dave