[Crash-utility] Re: [PATCH v2] help.c: Remove kmem -l help, messages
On 2023/12/25 16:31, Lianbo Jiang wrote:
On 12/15/23 14:57, devel-request(a)lists.crash-utility.osci.io wrote:
> Date: Fri, 15 Dec 2023 10:44:21 +0800
> From: Li Zhijian<lizhijian(a)fujitsu.com>
> Subject: [Crash-utility] [PATCH v2] help.c: Remove kmem -l help
> messages
> To:devel@lists.crash-utility.osci.io
> Cc: Li Zhijian<lizhijian(a)fujitsu.com>
> Message-ID:<20231215024421.2253282-1-lizhijian@fujitsu.com>
>
> -l option has existed when crash git project initialization, but its
> help message was not accurate(extra arguments a|i|ic|id was missing).
>
> In addition, these symbols required by -l option was for the very*old old*
> kernels, at least >= 2.6 don't include them. And it looks like this option
> has not been fixed for a long time.
>
> Instead of document this option, hide it from help messages.
Looks good to me. For the v2: Ack.
Thanks, applied.
https://github.com/crash-utility/crash/commit/38435c3acec075b076353ca28f5...
Kazu
>
> Thanks.
>
> Lianbo
>
>> Signed-off-by: Li Zhijian<lizhijian(a)fujitsu.com>
>> ---
>> help.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/help.c b/help.c
>> index cc7ab20e343e..d80e843703c1 100644
>> --- a/help.c
>> +++ b/help.c
>> @@ -6888,8 +6888,6 @@ char *help_kmem[] = {
>> " members of the associated page struct are displayed.",
>> " address when used with -c, the address must be a page pointer
address;",
>> " the page_hash_table entry containing the page is
displayed.",
>> -" address when used with -l, the address must be a page pointer
address;",
>> -" the page address is displayed if it is contained with the
list.",
>> " address when used with -v, the address can be a mapped kernel
virtual",
>> " address or physical address; the mapped region containing
the",
>> " address is displayed.\n",
>> -- 2.29.2