October 2025 - Crash-utility - Crash Utility List Archives

[PATCH] s390x: Always perform kernel address translation in vtop verbose mode.

by Mikhail Zaslonko

In s390x_kvtop() early return may take place despite the verbose flag. Thus we can miss page-table walk information in the vtop output for kernel virtual addresses. Make sure that s390x_vtop() is always called for kernel virtual addresses when the verbose flag is passed to s390x_kvtop() by do_vtop(). Suggested-by: Heiko Carstens <hca(a)linux.ibm.com> Signed-off-by: Mikhail Zaslonko <zaslonko(a)linux.ibm.com> --- s390x.c | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/s390x.c b/s390x.c index 8c0bba4..cb5a0dd 100644 --- a/s390x.c +++ b/s390x.c @@ -947,18 +947,15 @@ s390x_kvtop(struct task_context *tc, ulong vaddr, physaddr_t *paddr, int verbose if (!IS_KVADDR(vaddr)){ *paddr = 0; return FALSE; } - if (!vt->vmalloc_start) { - *paddr = VTOP(vaddr); - return TRUE; - } - - if (!IS_VMALLOC_ADDR(vaddr)) { - *paddr = VTOP(vaddr); - return TRUE; + if (!verbose) { + if (!vt->vmalloc_start || !IS_VMALLOC_ADDR(vaddr)) { + *paddr = VTOP(vaddr); + return TRUE; + } } pgd_base = (unsigned long)vt->kernel_pgd[0]; return s390x_vtop(pgd_base, vaddr, paddr, verbose); } -- 2.49.0

2 weeks

1
0
0 / 0

[PATCH] Loongarch: update the NR_CPUS to 2048

by Chenghao Duan

Since the kernel commit 9559d5806319 ("LoongArch: Increase max supported CPUs up to 2048")the NR_CPUS on Linux kernel ranges from 2-2048. So let's match NR_CPUS with the max NR_CPUS count on the Linux kernel. Signed-off-by: Chenghao Duan <duanchenghao(a)kylinos.cn> --- defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defs.h b/defs.h index 156ac02..c407ac4 100644 --- a/defs.h +++ b/defs.h @@ -169,7 +169,7 @@ #define NR_CPUS (256) #endif #ifdef LOONGARCH64 -#define NR_CPUS (256) +#define NR_CPUS (2048) #endif #define NR_DEVICE_DUMPS (64) -- 2.25.1

2 weeks, 1 day

1
0
0 / 0

[PATCH 1/2] s390x: Expand bt output with PSW mode and pt_regs address

by Mikhail Zaslonko

Print the following line for the stack frame with zero backchain pointer prior to printing PSW and GPRS: KERNEL-MODE INTERRUPT FRAME, pt_regs at <address>: or USER-MODE INTERRUPT FRAME, pt_regs at <address>: Suggested-by: Heiko Carstens <hca(a)linux.ibm.com> Signed-off-by: Mikhail Zaslonko <zaslonko(a)linux.ibm.com> --- s390x.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/s390x.c b/s390x.c index 0e8e2b3..b76edfa 100644 --- a/s390x.c +++ b/s390x.c @@ -1738,6 +1738,7 @@ static unsigned long show_trace(struct bt_info *bt, int cnt, unsigned long sp, /* Check for user PSW */ reg = readmem_ul(sp + MEMBER_OFFSET("pt_regs", "psw")); if (reg & S390X_PSW_MASK_PSTATE) { + fprintf(fp, " USER-MODE INTERRUPT FRAME, pt_regs at %llx:\n", sp); print_ptregs(bt, sp); return sp; } @@ -1750,6 +1751,7 @@ static unsigned long show_trace(struct bt_info *bt, int cnt, unsigned long sp, /* Check for loop (kernel_thread_starter) of second zero bc */ if (low == reg || reg == 0) return reg; + fprintf(fp, " KERNEL-MODE INTERRUPT FRAME, pt_regs at %llx:\n", sp); print_ptregs(bt, sp); low = sp; sp = reg; -- 2.49.0

2 weeks, 2 days

1
1
0 / 0

[PATCH v2 3/3] Enable resolving mangled Rust symbol in lockless ring buffer

by Lianbo Jiang

Without the patch: crash> log ... [ 2174.308966] Call Trace: [ 2174.311693] <TASK> [ 2174.314033] dump_stack_lvl+0x5d/0x80 [ 2174.318125] panic+0x156/0x32a [ 2174.321539] _RNvCscb18lrEyTSA_10rust_panic10area_in_hp+0xf7/0x120 [rust_panic] [ 2174.329700] ? console_unlock+0x9c/0x140 [ 2174.334080] ? irq_work_queue+0x2d/0x50 [ 2174.338352] ? __pfx_init_module+0x10/0x10 [rust_panic] [ 2174.344183] _RNvMCscb18lrEyTSA_10rust_panicNtB2_10HelloPanic8step_two+0x20/0xe0 [rust_panic] [ 2174.353698] ? _printk+0x6b/0x90 ... With the patch: crash> log ... [ 2174.308966] Call Trace: [ 2174.311693] <TASK> [ 2174.314033] dump_stack_lvl+0x5d/0x80 [ 2174.318125] panic+0x156/0x32a [ 2174.321539] rust_panic::area_in_hp+0xf7/0x120 [rust_panic] [ 2174.329700] ? console_unlock+0x9c/0x140 [ 2174.334080] ? irq_work_queue+0x2d/0x50 [ 2174.338352] ? __pfx_init_module+0x10/0x10 [rust_panic] [ 2174.344183] <rust_panic::HelloPanic>::step_two+0x20/0xe0 [rust_panic] [ 2174.353698] ? _printk+0x6b/0x90 ... Signed-off-by: Lianbo Jiang <lijiang(a)redhat.com> --- Note: 1. Add some checks to avoid the risk of buffer overflow. Makefile | 2 +- printk.c | 33 ++++++++++++++++++++++++++++++++- 2 files changed, 33 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index fc1c9588dcfa..b277129f6df2 100644 --- a/Makefile +++ b/Makefile @@ -421,7 +421,7 @@ kernel.o: ${GENERIC_HFILES} kernel.c ${CC} -c ${CRASH_CFLAGS} kernel.c -I${BFD_DIRECTORY} -I${GDB_INCLUDE_DIRECTORY} ${WARNING_OPTIONS} ${WARNING_ERROR} printk.o: ${GENERIC_HFILES} printk.c - ${CC} -c ${CRASH_CFLAGS} printk.c ${WARNING_OPTIONS} ${WARNING_ERROR} + ${CC} -c ${CRASH_CFLAGS} printk.c -I${GDB_INCLUDE_DIRECTORY} ${WARNING_OPTIONS} ${WARNING_ERROR} gdb_interface.o: ${GENERIC_HFILES} gdb_interface.c ${CC} -c ${CRASH_CFLAGS} gdb_interface.c ${WARNING_OPTIONS} ${WARNING_ERROR} diff --git a/printk.c b/printk.c index 95db7e607e4c..ae28c4fa0b21 100644 --- a/printk.c +++ b/printk.c @@ -1,5 +1,6 @@ #include "defs.h" #include <ctype.h> +#include "demangle.h" /* convenience struct for passing many values to helper functions */ struct prb_map { @@ -201,14 +202,44 @@ dump_record(struct prb_map *m, unsigned long id, int msg_flags) text = m->text_data + begin; + if (text_len > BUFSIZE) { + error(WARNING, "\nThe messages could be truncated!\n"); + text_len = BUFSIZE; + } + for (i = 0, p = text; i < text_len; i++, p++) { if (*p == '\n') fprintf(fp, "\n%s", space(ilen)); else if (isprint(*p) || isspace(*p)) - fputc(*p, fp); + sprintf(&buf[i], "%c", *p); else fputc('.', fp); } + /* + * Try to demangle a mangled Rust symbol(calltrace) from log buffer + */ + char *p1 = strstr(buf, "_R"); + if (!p1) + p1 = strstr(buf, "_ZN"); + char *p2 = strchrnul(buf, '+'); + if (p1 && p2) { + char mangled[BUFSIZE] = {0}; + char demangled[BUFSIZE] = {0}; + char *res; + size_t slen = p1 - buf; + + if (slen) + memcpy(demangled, buf, slen); + + memcpy(mangled, p1, p2-p1); + res = rust_demangle(mangled, DMGL_RUST); + if (res) { + snprintf(demangled+slen, BUFSIZE-slen, "%s%s", res, p2); + fprintf(fp, "%s",demangled); + free(res); + } + } else + fprintf(fp, "%s", buf); if (msg_flags & SHOW_LOG_DICT) { text = info + OFFSET(printk_info_dev_info) + -- 2.50.1

2 weeks, 5 days

1
0
0 / 0

[PATCH] Loongarch: update the NR_CPUS to 2048

by Chenghao Duan

Since the kernel commit 9559d5806319 ("LoongArch: Increase max supported CPUs up to 2048")the NR_CPUS on Linux kernel ranges from 2-2048. So let's match NR_CPUS with the max NR_CPUS count on the Linux kernel. Signed-off-by: Chenghao Duan <duanchenghao(a)kylinos.cn> --- defs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/defs.h b/defs.h index 3cb8e63..9af4b9e 100644 --- a/defs.h +++ b/defs.h @@ -169,7 +169,7 @@ #define NR_CPUS (256) #endif #ifdef LOONGARCH64 -#define NR_CPUS (256) +#define NR_CPUS (2048) #endif #define NR_DEVICE_DUMPS (64) -- 2.43.0

2 weeks, 6 days

1
0
0 / 0

[PATCH v2] vtop: Translate IEP flag for s390 region, segment and page entries

by Mikhail Zaslonko

Translate the IEP (Instruction Execution Protection) flag for Region-Third-Table entries and Segment-Table entries of Format Control 1 and also for Page-Table entries. Display the flags in s390x 'vtop' command output like shown below: STE: 0000000033be8ac0 => 0000000015803503 (flags = 03503) flags in binary : AV=0; ACC=0011; F=0; FC=1; P=0; IEP=1; I=0; CS=0; TT=0 or PTE: 00000000031c6fd8 => 000000000842e13d (flags = 13d) flags in binary : I=0; P=0; IEP=1 Suggested-by: Heiko Carstens <hca(a)linux.ibm.com> Signed-off-by: Mikhail Zaslonko <zaslonko(a)linux.ibm.com> --- v1->v2: - Also translate IEP flag for Page-Table entries s390x.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/s390x.c b/s390x.c index 0e8e2b3..8c0bba4 100644 --- a/s390x.c +++ b/s390x.c @@ -29,6 +29,7 @@ #define S390X_PTE_FLAG_BITS 0xfffULL /* Page table entry flag bits */ #define S390X_PAGE_PRESENT 0x001ULL /* set: loaded in physical memory * clear: not loaded in physical mem */ +#define S390X_PAGE_IEP 0x100ULL /* Instruction-execution protection */ #define S390X_PAGE_RO 0x200ULL /* HW read-only */ #define S390X_PAGE_INVALID 0x400ULL /* HW invalid */ #define S390X_PAGE_INVALID_MASK 0x601ULL /* for linux 2.6 */ @@ -65,6 +66,7 @@ #define S390X_RTE_TF 0xc0ULL #define S390X_RTE_TF_10 0x80ULL #define S390X_RTE_TF_01 0x40ULL +#define S390X_RTE_IEP 0x100ULL #define S390X_RTE_P 0x200ULL #define S390X_RTE_FC 0x400ULL #define S390X_RTE_F 0x800ULL @@ -82,6 +84,7 @@ #define S390X_STE_TT_01 0x4ULL #define S390X_STE_CS 0x10ULL #define S390X_STE_I 0x20ULL +#define S390X_STE_IEP 0x100ULL #define S390X_STE_P 0x200ULL #define S390X_STE_FC 0x400ULL #define S390X_STE_F 0x800ULL @@ -979,7 +982,7 @@ static inline int s390x_pte_present(unsigned long x){ /* Print flags of Segment-Table entry with format control = 1 */ static void print_segment_entry_fc1(ulong val) { - fprintf(fp, "AV=%u; ACC=%u%u%u%u; F=%u; FC=%u; P=%u; I=%u; CS=%u; TT=%u%u\n", + fprintf(fp, "AV=%u; ACC=%u%u%u%u; F=%u; FC=%u; P=%u; IEP=%u; I=%u; CS=%u; TT=%u%u\n", !!(val & S390X_STE_AV), !!(val & S390X_STE_ACC_1000), !!(val & S390X_STE_ACC_0100), @@ -988,6 +991,7 @@ static void print_segment_entry_fc1(ulong val) !!(val & S390X_STE_F), !!(val & S390X_STE_FC), !!(val & S390X_STE_P), + !!(val & S390X_STE_IEP), !!(val & S390X_STE_I), !!(val & S390X_STE_CS), !!(val & S390X_STE_TT_10), @@ -1009,7 +1013,7 @@ static void print_segment_entry_fc0(ulong val) /* Print flags of Region-Third-Table entry with format control = 1 */ static void print_region_third_entry_fc1(ulong val) { - fprintf(fp, "AV=%u; ACC=%u%u%u%u; F=%u; FC=%u; P=%u; I=%u; CR=%u; TT=%u%u\n", + fprintf(fp, "AV=%u; ACC=%u%u%u%u; F=%u; FC=%u; P=%u; IEP=%u; I=%u; CR=%u; TT=%u%u\n", !!(val & S390X_RTE_AV), !!(val & S390X_RTE_ACC_1000), !!(val & S390X_RTE_ACC_0100), @@ -1018,6 +1022,7 @@ static void print_region_third_entry_fc1(ulong val) !!(val & S390X_RTE_F), !!(val & S390X_RTE_FC), !!(val & S390X_RTE_P), + !!(val & S390X_RTE_IEP), !!(val & S390X_RTE_I), !!(val & S390X_RTE_CR), !!(val & S390X_RTE_TT_10), @@ -1151,8 +1156,10 @@ static ulong _kl_pg_table_deref_s390x(ulong vaddr, ulong table, int verbose) if (verbose) { fprintf(fp, "%5s: %016lx => %016lx (flags = %03llx)\n", "PTE", addr, entry, entry & S390X_PTE_FLAG_BITS); - fprintf(fp, " flags in binary : I=%u; P=%u\n", - !!(entry & S390X_PAGE_INVALID), !!(entry & S390X_PAGE_RO)); + fprintf(fp, " flags in binary : I=%u; P=%u; IEP=%u\n", + !!(entry & S390X_PAGE_INVALID), + !!(entry & S390X_PAGE_RO), + !!(entry & S390X_PAGE_IEP)); fprintf(fp, "%5s: %016llx\n", "PAGE", entry & ~S390X_PTE_FLAG_BITS); } /* -- 2.49.0

3 weeks, 1 day

2
1
0 / 0

[PATCH] Fix the misleading uncompress error message

by Tao Liu

The "unxz" is missing for uncompressing fail message. Fix [1]. [1]: https://github.com/crash-utility/crash/issues/220 Signed-off-by: Tao Liu <ltao(a)redhat.com> --- symbols.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/symbols.c b/symbols.c index ee3cba1..e6af38b 100644 --- a/symbols.c +++ b/symbols.c @@ -4481,8 +4481,9 @@ is_compressed_kernel(char *file, char **tmp) } if (system(command) < 0) { please_wait_done(); - error(INFO, "%s of %s failed\n", - type == GZIP ? "gunzip" : "bunzip2", file); + error(INFO, "%s of %s failed\n", + type == GZIP ? "gunzip" : + (type == BZIP2 ? "bunzip2" : "unxz"), file); free(tempname); return FALSE; } -- 2.47.0

3 weeks, 2 days

1
0
0 / 0

[PATCH 2/v2] Fix "mount" MNT_CURSOR (kernels 5.8-6.7)

by Aureau, Georges (Kernel Tools ERT)

[PATCH 2/v2] Fix "mount" MNT_CURSOR (kernels 5.8-6.7): Fix "mount" MNT_CURSOR entries (kernels 5.8-6.7): crash> mount > mount.out WARNING: cannot get super_block from vfsmnt: 0xff35d65eb1cc1820 crash> struct mount.mnt.mnt_sb,mnt.mnt_flags -x 0xff35d65eb1cc1820 mnt.mnt_sb = 0x0, mnt.mnt_flags = 0x10000000, When crashing with running "findmnt" commands, the mount list will have entries with mnt.mnt_flags==MNT_CURSOR (and mnt.mnt_sb==NULL). Such entries should be skipped without errors. Signed-off-by: Georges Aureau <georges.aureau(a)hpe.com> -- defs.h | 2 ++ filesys.c | 15 +++++++++++++++ symbols.c | 4 ++++ 3 files changed, 21 insertions(+) diff --git a/defs.h b/defs.h index 156ac02..3fd7d89 100644 --- a/defs.h +++ b/defs.h @@ -2274,6 +2274,8 @@ struct offset_table { /* stash of commonly-used offsets */ long request_queue_tag_set; long blk_mq_tag_set_flags; long blk_mq_tag_set_shared_tags; + long vfsmount_mnt_flags; + long proc_mounts_cursor; }; struct size_table { /* stash of commonly-used sizes */ diff --git a/filesys.c b/filesys.c index 8d13807..1f8803d 100644 --- a/filesys.c +++ b/filesys.c @@ -1367,6 +1367,10 @@ cmd_mount(void) close_tmpfile(); } +/* For kernels 5.8-6.7, we're skipping show mount cursor entries. + */ +#define MNT_CURSOR 0x10000000 + /* * Do the work for cmd_mount(); */ @@ -1492,6 +1496,15 @@ show_mounts(ulong one_vfsmount, int flags, struct task_context *namespace_contex sbp = ULONG(vfsmount_buf + OFFSET(vfsmount_mnt_sb)); if (!IS_KVADDR(sbp)) { + if (sbp == 0 && VALID_MEMBER(proc_mounts_cursor) && + VALID_MEMBER(vfsmount_mnt_flags)) { + int mnt_flags = INT(vfsmount_buf + OFFSET(vfsmount_mnt_flags)); + if (mnt_flags == MNT_CURSOR) { + if (CRASHDEBUG(1)) + fprintf(stderr,"skipped cursor vfsmnt: 0x%lx\n", *vfsmnt); + continue; + } + } error(WARNING, "cannot get super_block from vfsmnt: 0x%lx\n", *vfsmnt); continue; } @@ -2081,6 +2094,8 @@ vfs_init(void) if (INVALID_MEMBER(vfsmount_mnt_devname)) MEMBER_OFFSET_INIT(mount_mnt_mountpoint, "mount", "mnt_mountpoint"); + MEMBER_OFFSET_INIT(vfsmount_mnt_flags, "vfsmount", "mnt_flags"); + MEMBER_OFFSET_INIT(proc_mounts_cursor, "proc_mounts", "cursor"); MEMBER_OFFSET_INIT(mount_mnt, "mount", "mnt"); MEMBER_OFFSET_INIT(namespace_root, "namespace", "root"); MEMBER_OFFSET_INIT(task_struct_nsproxy, "task_struct", "nsproxy"); diff --git a/symbols.c b/symbols.c index 112bcc6..fd91c2e 100644 --- a/symbols.c +++ b/symbols.c @@ -10691,6 +10691,10 @@ dump_offset_table(char *spec, ulong makestruct) OFFSET(vfsmount_mnt_mountpoint)); fprintf(fp, " vfsmount_mnt_parent: %ld\n", OFFSET(vfsmount_mnt_parent)); + fprintf(fp, " vfsmount_mnt_flags: %ld\n", + OFFSET(vfsmount_mnt_flags)); + fprintf(fp, " proc_mounts_cursor: %ld\n", + OFFSET(proc_mounts_cursor)); fprintf(fp, " mount_mnt_parent: %ld\n", OFFSET(mount_mnt_parent)); fprintf(fp, " mount_mnt_mountpoint: %ld\n",

3 weeks, 2 days

1
0
0 / 0

[PATCH 1/v2] Fix "mount <address>"

by Aureau, Georges (Kernel Tools ERT)

[PATCH 1/v2] Fix "mount <address>" The command "mount <address>" is failing on kernels without "super_block.s_files": crash> mount ff35d61d80200000 mount: the super_block.s_files linked list does not exist in this kernel mount: -f option not supported or applicable on this architecture or kernel The MOUNT_PRINT_FILES flags should only be passed when "super_block.s_files" is available. Signed-off-by: Georges Aureau <georges.aureau(a)hpe.com> -- diff --git a/filesys.c b/filesys.c index 8d13807..b4d4f02 100644 --- a/filesys.c +++ b/filesys.c @@ -1296,7 +1296,7 @@ cmd_mount(void) * through it for each search argument entered. */ open_tmpfile(); - show_mounts(0, MOUNT_PRINT_FILES | + show_mounts(0, (VALID_MEMBER(super_block_s_files) ? MOUNT_PRINT_FILES : 0) | (VALID_MEMBER(super_block_s_dirty) ? MOUNT_PRINT_INODES : 0), namespace_context);

3 weeks, 2 days

1
0
0 / 0

[PATCH] Fix get_pathname() not handling stacked mounts

by Aureau, Georges (Kernel Tools ERT)

[PATCH] Fix get_pathname() not handling stacked mounts This get_pathname() issue can be duplicated as follow: sudo mkdir -p /tmp/test sudo mount -t tmpfs tmpfs /tmp/test sudo mount --make-private /tmp/test sudo mount --bind /tmp/test /tmp/test sudo mount --bind /tmp/test /tmp/test sudo mount -o remount,ro /tmp/test $ sudo crash /usr/lib/debug/boot/vmlinux-$(uname -r) crash> mount | grep /tmp/test ffff9648e7febc00 ffff9648d91ac800 tmpfs tmpfs /tmp/test ffff9648c9281380 ffff9648d91ac800 tmpfs tmpfs /tmp/test/ ffff9648c8e9a700 ffff9648d91ac800 tmpfs tmpfs / The last mount is not printed properly, and this is impacting diagnostic when looking at vmcore from complex containers mount environments. Signed-off-by: Georges Aureau <georges.aureau(a)hpe.com> -- diff --git a/filesys.c b/filesys.c index 8d13807..af6d616 100644 --- a/filesys.c +++ b/filesys.c @@ -3140,6 +3154,7 @@ get_pathname(ulong dentry, char *pathname, int length, int full, ulong vfsmnt) tmp_vfsmnt = vfsmnt; do { + more_vfsmnt: tmp_dentry = parent; dentry_buf = fill_dentry_cache(tmp_dentry); @@ -3195,6 +3210,7 @@ get_pathname(ulong dentry, char *pathname, int length, int full, ulong vfsmnt) break; else tmp_vfsmnt = mnt_parent; + goto more_vfsmnt; } } else if (VALID_STRUCT(mount)) { if (tmp_vfsmnt) { @@ -3213,6 +3229,7 @@ get_pathname(ulong dentry, char *pathname, int length, int full, ulong vfsmnt) break; else tmp_vfsmnt = mnt_parent + OFFSET(mount_mnt); + goto more_vfsmnt; } } else { @@ -3222,6 +3239,9 @@ get_pathname(ulong dentry, char *pathname, int length, int full, ulong vfsmnt) } } while (tmp_dentry != parent && parent); + if (!STREQ(pathname, "/") && LASTCHAR(pathname) == '/') { + LASTCHAR(pathname) = '\0'; + } if (mnt_buf) FREEBUF(mnt_buf);

3 weeks, 2 days

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Crash-utility October 2025