Re: [Crash-utility] Adding a new command rbtree
----- Original Message -----
I haven't tinkered with the -p option, although I don't think
that it's
a particularly important option. I may add a couple more error-handling
additions, and perhaps some slight user interface changes, and the help
page needs to be cleaned-up/clarified. But aside from that, this is
looking pretty good for inclusion in crash-6.0.8.
No further patch posting is required unless you find a new bug or other
problem -- nice job!
And just in case you notice these, no further patch is required -- I've got
them fixed:
1. I removed the TREE_START_ENTERED #define since it's unused.
2. This error message uses the wrong offset value, it should use the local
"root_offset" variable:
case 'r':
if (td->flags & TREE_ROOT_OFFSET_ENTERED)
error(FATAL,
"root offset value %d (0x%lx) already
entered\n",
td->member_offset, td->member_offset);
3. The rdtree_interation() function did not do an hq_enter() of each slot entry
to check for duplicates.
4. FYI -- whenever you add new entries to the offset_table[] array, please put
them at the end of the array so that extension modules that were built with
an older "defs.h" will still see the same offsets. The new entries can be
still
be displayed next to similar members as you've done in dump_offset_table().
(and thanks for remembering to do that -- most people forget or are unaware of
the function).
Thanks,
Dave
Dave