Re: [Crash-utility] [PATCH] add -s option to vm to display one vma at a time

----- Original Message ----- Seems like a reasonable request. However, I don't like your mixing it with the "-R reference" usage, because it confuses things like this simple example: crash> vm -p -s ffff810ec9f57818 VMA START END FLAGS FILE ffff810ec9f57818 4010d000 40110000 101877 /usr/local/java/jdk1.5.0_19/bin/java VIRTUAL PHYSICAL 4010d000 ec89b1000 4010e000 FILE: /usr/local/java/jdk1.5.0_19/bin/java OFFSET: e000 4010f000 e99803000 crash> If the command above were to be qualified with a "-R 4010e000" reference check, it results in a nonsensical error message: crash> vm -p -s ffff810ec9f57818 -R 4010e000 vm: only one -R option allowed Usage: vm [-p | -v | -m | [-R reference] | [-f vm_flags]] [pid | taskp] ... Enter "help vm" for details. crash> A few suggestions: (1) Don't even bother to tie it in with the "vm -v" option, because if you already know the vm_area_struct address, then just print it with "vm_area_struct <address>". (2) Then, since it *only* applies with the -p functionality, make it a new "-P <vmaddr>" option, where the help page explains that the <vmaddr> argument must be a vm_area_struct of the current context: Usage: vm [-p | -P vmaddr | -v | -m | [-R reference] | [-f vm_flags]] [pid | taskp] ... (3) Make -P mutually exclusive with all of the other options. (4) Do not use the reference structure for this feature. Just use your new flag, and pass the vma address in the 3rd "vaddr" argument to vm_area_dump(), since it's not even being used by cmd_vm(). Dave