On 2022/09/01 19:00, lijiang wrote:
Hi, Chunguang
Thank you for the improvement.
On Thu, Aug 25, 2022 at 2:52 PM <crash-utility-request(a)redhat.com> wrote:
> Date: Thu, 25 Aug 2022 12:07:20 +0800
> From: brookxu <brookxu.cn(a)gmail.com>
> To: crash-utility(a)redhat.com
> Subject: [Crash-utility] [PATCH] filesys.c: add debian vmlinux loc to
> default search dirs
> Message-ID: <20220825040720.108590-1-brookxu.cn(a)gmail.com>
> Content-Type: text/plain; charset="US-ASCII"; x-default=true
>
> From: "Chunguang.Xu" <chunguang.xu(a)shopee.com>
>
> Now crash cannnot found debian/ubuntu kernel vmlinux, we need
> to explicitly specify the path to vmlinux. Try to add the debian
> vmlinux location to default search dirs.
>
> Signed-off-by: Chunguang Xu <chunguang.xu(a)shopee.com>
> ---
> filesys.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/filesys.c b/filesys.c
> index a863f04..c2ea78d 100644
> --- a/filesys.c
> +++ b/filesys.c
> @@ -319,7 +319,7 @@ match_proc_version(void)
>
> #define CREATE 1
> #define DESTROY 0
> -#define DEFAULT_SEARCHDIRS 5
> +#define DEFAULT_SEARCHDIRS 6
>
Given that the remote.c module is basically deprecated, this change should
be fine for now. So: Ack.
Yes, it's fine.
Applied.
https://github.com/crash-utility/crash/commit/5b9d3e98cda9d99f3277aabec30...
Thanks,
Kazu