Re: [Crash-utility] [PATCH] ppc64: still allow to move on if the emergency stacks info fails to initialize
On Sat, Oct 8, 2022 at 12:27 PM lijiang <lijiang(a)redhat.com> wrote:
> --- a/ppc64.c
> +++ b/ppc64.c
> @@ -1947,7 +1947,7 @@ ppc64_in_emergency_stack(int cpu, ulong addr, bool verbose)
> if (cpu < 0 || cpu >= kt->cpus)
> return NONE_STACK;
>
> - if (ms->emergency_sp) {
> + if (ms->emergency_sp && ms->emergency_sp[cpu]) {
Is it better to use the IS_KVADDR(ms->emergency_sp[cpu]) ? For example:
+ if (ms->emergency_sp && IS_KVADDR(ms->emergency_sp[cpu]) ) {
Yes, looks better. Please go ahead with this.
Thanks,
Kazu