Re: [Crash-utility] [PATCH] Fix memory leaks in dump_mem_map when SPARSEMEM is enabled

Date: Tue, 16 Jun 2015 12:32:29 -0400 From: anderson(a)redhat.com To: crash-utility(a)redhat.com Subject: Re: [Crash-utility] [PATCH] Fix memory leaks in dump_mem_map when SPARSEMEM is enabled ----- Original Message ----- > > Date: Tue, 16 Jun 2015 11:14:51 -0400 > > From: anderson(a)redhat.com > > To: crash-utility(a)redhat.com > > Subject: Re: [Crash-utility] [PATCH] Fix memory leaks in dump_mem_map when > > SPARSEMEM is enabled > > > > > > Hi Oliver, > > > > Since it's a GETBUF() call, it's not really a memory leak (by design). > > Dave, > > Sorry, I'm not familiar the code. > > If the dump_mem_map get called in a thousand loop, the crash could reported > memory allocation errors and exit the loop. Yes, except for the fact that dump_mem_map() is never called in a loop. But since your proposed patch does that, then yes, it would be a problem. Dave