Re: [Crash-utility] [PATCH v3 0/2] Crash-Utility: crash enhancement to support s390x diskdump
Hello Dave,
Dave Anderson <anderson(a)redhat.com> wrote on 11/16/2010 20:30:48:
Correct, machine_type("S390") can be removed, because we currently can't have s390 31 bit ELF dumps or kdumps. And probably
will never
have.
Michael
> Please review the changes and send in your comments.
Hello Mahesh,
The patch-set looks good so far, except for one minor nit.
Why is "S390" accepted as legitimate here in read_dump_header()?
@@ -349,6 +352,10 @@ restart:
dd->machine_type = EM_IA_64;
else if (machine_type("PPC64"))
dd->machine_type = EM_PPC64;
+ else if (machine_type("S390"))
+ dd->machine_type = EM_S390;
+ else if (machine_type("S390X"))
+ dd->machine_type = EM_S390;
else {
error(INFO, "%s: unsupported machine type: %s\n",
DISKDUMP_VALID() ? "diskdump" : "compressed
kdump",