Re: [Crash-utility] [PATCH 0/3] Show that the kernel is tainted at init-time

Hi Aaron, sorry for the delay. -----Original Message----- That would be usuful and looks more readable, thanks. To stop the compilation warning below, with initializing the variables, Acked-by: Kazuhito Hagio <k-hagio-ab(a)nec.com&gt; cc -c -g -DX86_64 -DLZO -DSNAPPY -DZSTD -DGDB_10_2 kernel.c -Wall -O2 -Wstrict-prototypes -Wmissing-prototypes -fstack-protector -Wformat-security kernel.c: In function ‘show_kernel_taints’: kernel.c:11268:12: warning: ‘sp’ may be used uninitialized in this function [-Wmaybe-uninitialized] tnts_addr = sp->value; ~~~~~~~~~~^~~~~~~~~~~ kernel.c:11222:6: warning: ‘tnts_len’ may be used uninitialized in this function [-Wmaybe-uninitialized] int tnts_len; ^~~~~~~~ --- a/kernel.c +++ b/kernel.c @@ -11219,11 +11219,11 @@ show_kernel_taints(char *buf, int verbose) int i, bx; uint8_t tnt_bit; char tnt_true, tnt_false; - int tnts_len; + int tnts_len = 0; ulong tnts_addr; ulong tainted_mask, *tainted_mask_ptr; int tainted; - struct syment *sp; + struct syment *sp = NULL; if (kernel_symbol_exists("tainted")) { get_symbol_data("tainted", sizeof(int), &tainted);