[Crash-utility] Re: [PATCH] vmcoreinfo: read vmcoreinfo using 'vmcoreinfo_data' when unavailable in elf note

Hi Lianbo, On 25/07/23 09:53AM, lijiang wrote: > <...snip...> > > > > I have seen two versions of the implementation, another one is in > netdump.c. Can we do it like this? > > bool is_vmcoreinfo_empty(void) > { > if (dd && dd->sub_header_kdump) > return (dd->sub_header_kdump->size_vmcoreinfo == 0); > if (nd) > return (nd->size_vmcoreinfo == 0); > return true; > } > > And implement it in a common file, E.g: kernel.c, put its definition to > defs.h. So that we can call this one in netdump.c and diskdump.c. > What do you think? Sure, makes sense. Will do it.