On 2022/09/02 14:48, lijiang wrote:
On Thu, Sep 1, 2022 at 12:56 PM HAGIO KAZUHITO(萩尾 一仁)
<k-hagio-ab(a)nec.com>
wrote:
> Without the patch, the following gcc-11 compiler warnings are emitted
> for gdb-10.2/gdb/symtab.c:
>
> symtab.c: In function 'void gdb_get_datatype(gnu_request*)':
> symtab.c:7131:31: warning: ISO C++17 does not allow 'register' storage
> class specifier [-Wregister]
> 7131 | register struct type *type;
> | ^~~~
> symtab.c:7132:31: warning: ISO C++17 does not allow 'register' storage
> class specifier [-Wregister]
> 7132 | register struct type *typedef_type;
> | ^~~~~~~~~~~~
> ...
>
> Usually we don't fix compiler warnings for gdb, but these are emitted
> even by "make clean ; make warn", which doesn't recompile the whole
> gdb, so it would be better to fix.
>
> Signed-off-by: Kazuhito Hagio <k-hagio-ab(a)nec.com>
> ---
> v2
> - rebased to the current gdb-10.2.patch.
>
> gdb-10.2.patch | 41 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
>
>
Looks good to me. So: Ack
Thanks, applied.
Kazu