Hi Kazu,
On Tue, Mar 01, 2022 at 01:00:39AM +0000, HAGIO KAZUHITO(萩尾 一仁) wrote:
> case POST_GDB:
> - arm64_calc_virtual_memory_ranges();
> + /* Can we get the size of struct page before POST_GDB */
> + if (!ASSIGN_SIZE(page))
> + arm64_calc_virtual_memory_ranges();
I don't have an arm machine and cannot test, but the ASSIGN_SIZE(page)
== size_table.page is re-initialized to -1 in datatype_init() after
machdep_init(PRE_GDB), so it looks like the !ASSIGN_SIZE(page) is
always zero.
Yes, you are right.
It may be good to add another variable e.g. ms->struct_page_size /* for early use */
or something, as this usage of the size_table is unusual and confusing.
Okay,
thanks for pointing this.
I will use it in next version.
Thanks
Huang Shijie