[Crash-utility] Re: [PATCH v2] symbols: expand all kernel module symtable if not all expanded previously

On Thu, Nov 30, 2023 at 3:56 PM HAGIO KAZUHITO(萩尾 一仁) <k-hagio-ab(a)nec.com&gt; wrote: > On 2023/11/30 0:31, Tao Liu wrote: > >>> And I did not see the debuginfo again(only one time): >>> gdb_get_line_number 7101 >>> >>> Did I miss anything else? > > Is there no case where sal.symtab == NULL after expansion? > I don't think of, but e.g. a wrong address is requested. > > personally I'm ok with the current patch for fail-safe, quite a simple one. > > also reverting is troublesome... this is my fault though. > > No worries, Kazu. If any risks are found in the future, we can try to fix them. Let's leave it there for now. Just an idea, no other specific concerns.