Re: [Crash-utility] [PATCH} crash 4.0-2.8 fixes to make itworkonx86_64 for 2.6.14
On Thu, 2005-11-03 at 16:29 -0500, Dave Anderson wrote:
Badari Pulavarty wrote:
> Dave,
>
> Here is the latest patch to make crash work on 2.6.14 kernel -
> with fixes for 4-level pagetables also.
>
> I changes & naming are kind of hacky (especially with naming)
> -- but to cleanup it completely and have backward compatibility
> needs more work. We should get rid of PML4 completely and
> move to PGD/PUD/PMD/PTE.
>
> Thanks,
> Badari
>
That's some nice work you've done here -- I can't thank you enough!
But are you saying that with this patch, it does *not* have backwards-compatibility?
It looks like you've completely segregated the new code to me.
This patch does provide backward compatibility (I tested with 2.6.10 and
2.6.14).
My complaint is the naming convention, for longterm maintenance:
For user virtual - before 2.6.10 we have only 3-level pagetables
but now we have 4-level page tables. What used to be PGD (before
2.6.10) now became PUD and so on..
2.6.10 2.6.14
no 4 level == PGD
PGD == PUD
PMD == PMD
PTE == PTE
Thanks,
Badari