Re: [Crash-utility] [PATCH v3 0/3] vmalloc translation support for PPC

> So just do the same thing -- no verbose expanation is required. There are two ways to fix this : 1) Fix dump_mem_map*() to print the header only when there is information to dump. --- a/memory.c +++ b/memory.c @@ -4637,13 +4637,6 @@ dump_mem_map_SPARSEMEM(struct meminfo *mi) continue; } - if (print_hdr) { - if (!(pc->curcmd_flags & HEADER_PRINTED)) - fprintf(fp, "%s", hdr); - print_hdr = FALSE; - pc->curcmd_flags |= HEADER_PRINTED; - } - pp = section_mem_map_addr(section); pp = sparse_decode_mem_map(pp, section_nr); phys = (physaddr_t) section_nr * PAGES_PER_SECTION() * PAGESIZE(); @@ -4854,6 +4847,13 @@ dump_mem_map_SPARSEMEM(struct meminfo *mi) } if (bufferindex > buffersize) { + if (print_hdr) { + if (!(pc->curcmd_flags & HEADER_PRINTED)) + fprintf(fp, "%s", hdr); + print_hdr = FALSE; + pc->curcmd_flags |= HEADER_PRINTED; + } + fprintf(fp, "%s", outputbuffer); bufferindex = 0; } @@ -4867,6 +4867,13 @@ dump_mem_map_SPARSEMEM(struct meminfo *mi) } if (bufferindex > 0) { + if (print_hdr) { + if (!(pc->curcmd_flags & HEADER_PRINTED)) + fprintf(fp, "%s", hdr); + print_hdr = FALSE; + pc->curcmd_flags |= HEADER_PRINTED; + } + fprintf(fp, "%s", outputbuffer); } Similarly for the dump_mem_map(). 2) Fix ppc_pgd_vtop() to return FALSE if the paddr > machdep->memsize --- a/ppc.c +++ b/ppc.c @@ -438,6 +438,10 @@ ppc_pgd_vtop(ulong *pgd, ulong vaddr, physaddr_t *paddr, int verbose) *paddr = PAGEBASE(pte) + PAGEOFFSET(vaddr); + if (*paddr > machdep->memsize) + /* We don't have pages above System RAM */ + return FALSE; + return TRUE; no_page: I prefer the (1). What do you think ?