Re: [Crash-utility] [PATCH] extensions/trace: Fix ftrace_get_event_type_name()
Namhyung,
In the absence of a response from the maintainer, and since backwards
compatibility should not be a problem given that the modified code path
is not run in older kernels, I've checked this into github, where it is
queued for crash-7.1.6:
https://github.com/crash-utility/crash/commit/6341fe52dd35ded8b0ee10d3b86...
Note that the change won't be reflected in the trace.c file referenced in
http://people.redhat.com/anderson/extensions.html#TRACE until crash-7.1.6
is released. Until then, it can be accessed by cloning
git://github.com/crash-utility/crash.git
Thanks,
Dave
----- Original Message -----
On Sat, Jul 09, 2016 at 08:21:43PM +0900, Namhyung Kim wrote:
> The recent kernel change dcb0b5575d24 ("tracing: Remove
> TRACE_EVENT_FL_USE_CALL_FILTER logic") changed the bit index so it makes
> checking TRACE_EVENT_FL_TRACEPOINT flag failed. It should be 0x20 for
> newer kernels. Without this patch, the crash tool refused to load
> trace.so extension due to invalid access to event names:
>
> crash> extend trace.so
> extend: /path/to/crash/extensions/trace.so: no commands registered:
> shared object unloaded
>
> Instead of using the hard-coded value, read the enum value from the
> kernel dynamically.
>
> Reported-by: Minchan Kim <minchan(a)kernel.org>
> Cc: Steven Rostedt <rostedt(a)goodmis.org>
> Signed-off-by: Namhyung Kim <namhyung(a)gmail.com>
Tested-by: Minchan Kim <minchan(a)kernel.org>
It works!
Thanks, Namhyung.
--
Crash-utility mailing list
Crash-utility(a)redhat.com
https://www.redhat.com/mailman/listinfo/crash-utility