[Crash-utility] Re: [PATCH v2 2/2] s390x: Always perform kernel address translation in vtop verbose mode

>> @@ -943,15 +943,15 @@ s390x_kvtop(struct task_context *tc, ulong vaddr, physaddr_t *paddr, int verbose >> >> if (!IS_KVADDR(vaddr)){ >> *paddr = 0; >> return FALSE; >> } >> >> - if (!IS_VMALLOC_ADDR(vaddr)) { >> - *paddr = VTOP(vaddr); >> - return TRUE; >> + if (!verbose && !IS_VMALLOC_ADDR(vaddr)) { >> + *paddr = VTOP(vaddr); >> + return TRUE; > > Few other architectures do it like this: > > if (!vt->vmalloc_start) { > *paddr = VTOP(kvaddr); > return TRUE; > } > if (!IS_VMALLOC_ADDR(kvaddr)) { > *paddr = VTOP(kvaddr); > if (!verbose) > return TRUE; > } > > Would it work for s390x? It would, but does it make sense updating *paddr value for non-verbose case prior to calling s390x_vtop() where we set it back to zero at the very start (see below).

Do you think we should just try keeping the code similar to other architectures?

/* lookup virtual address in page tables */ int s390x_vtop(ulong table, ulong vaddr, physaddr_t *phys_addr, int verbose) { ulong entry, paddr; int level, len; if (verbose) fprintf(fp, "PAGE DIRECTORY: %016lx\n", table); *phys_addr = 0;