On 2023/03/24 11:47, lijiang wrote:
On Fri, Mar 24, 2023 at 8:45 AM HAGIO KAZUHITO(萩尾 一仁)
<k-hagio-ab(a)nec.com>
wrote:
> hmm, what does "special value" mean? I think that htoll() skips
'h'
to accept strings like '1234h', so "0xh" is just converted to zero.
> I'm not sure why you pick the "0xh" up specially here.
>
>
The "special value" means that the value "0xh" is ambiguous, the
htoll()
always
skips the "h", but for users, the "0xh" is actually a value(though it
is an
invalid value).
And similar strings like "123h456",...
But this is another issue, as you mentioned below.
Yes.
>
> As I said before, this is the expected behavior. Mistakenly?
>
>
OK, let's remove it from the patch log.
> The issue that this patch fixes is the confusion by the option.
> The '0xh' is beside the point. I've rewrite it, how about this?
>
>
The following patch log is fine to me.
thanks, applied with it.
https://github.com/crash-utility/crash/commit/4ced103422610b8b41c279794ba...
Thanks,
Kazu