Re: [Crash-utility] [PATCH] runq: make tasks in throttled cfs_rqs/rt_rqs displayed

> For clarity, I changed the output slightly to show the per-cpu task_group rt_rq > and cfs_rq pointers above their respective queues. (The rt_rq and rt prio_array > addresses are the same because of the structure layout, but that's not > necessarily always going to be true.) And I tried to make the help page > description a little cleaner. So here's what it looks like: > > crash> help runq > ... [ cut ] ... > > -g Display tasks hierarchically by task_group. Tasks in > throttled groups > are also displayed. > > ... [cut] ... > > Display tasks hierarchically by task_group: > > crash> runq -g > CPU 0 > CURRENT: PID: 14734 TASK: ffff88010626f500 COMMAND: "sh" > TASK_GROUP RT_RQ: ffff880028216808 > RT PRIO_ARRAY: ffff880028216808 > [ 0] GROUP RT PRIO_ARRAY: ffff880139fc9800 <test1> (THROTTLED) > [ 0] PID: 14750 TASK: ffff88013a4dd540 COMMAND: "rtloop99" > [ 1] PID: 14748 TASK: ffff88013bbca040 COMMAND: "rtloop98" > [ 1] GROUP RT PRIO_ARRAY: ffff880089029000 <test11> > [ 1] PID: 14752 TASK: ffff880088abf500 COMMAND: "rtloop98" > [ 54] PID: 14749 TASK: ffff880037a4e080 COMMAND: "rtloop45" > [ 98] PID: 14746 TASK: ffff88012678c080 COMMAND: "rtloop1" > TASK_GROUP CFS_RQ: ffff8800282166e8 > CFS RB_ROOT: ffff880028216718 > [120] PID: 14740 TASK: ffff88013b1e6080 COMMAND: "sh" > [120] PID: 14738 TASK: ffff88012678d540 COMMAND: "sh" > GROUP CFS RB_ROOT: ffff8800897af430 <test2> (THROTTLED) > [120] PID: 14732 TASK: ffff88013bbcb500 COMMAND: "sh" > [120] PID: 14728 TASK: ffff8800b3496080 COMMAND: "sh" > [120] PID: 14730 TASK: ffff880037833540 COMMAND: "sh" > GROUP CFS RB_ROOT: ffff880037943e30 <test1> (THROTTLED) > [120] PID: 14726 TASK: ffff880138d42aa0 COMMAND: "sh" > > CPU 1 > CURRENT: PID: 3269 TASK: ffff88013b0fa040 COMMAND: "bash" > TASK_GROUP RT_RQ: ffff880028296808 > RT PRIO_ARRAY: ffff880028296808 > [ 0] GROUP RT PRIO_ARRAY: ffff88008a1f5000 <test1> (THROTTLED) > [ 0] GROUP RT PRIO_ARRAY: ffff880121774800 <test11> > [ 0] PID: 14753 TASK: ffff88013bbbaae0 COMMAND: "rtloop99" > [ 98] PID: 14745 TASK: ffff880126763500 COMMAND: "rtloop1" > [ 98] PID: 14747 TASK: ffff88013b1e6ae0 COMMAND: "rtloop1" > TASK_GROUP CFS_RQ: ffff8800282966e8 > CFS RB_ROOT: ffff880028296718 > GROUP CFS RB_ROOT: ffff8800896eac30 <test1> > [120] PID: 14724 TASK: ffff880139632080 COMMAND: "sh" > [120] PID: 14742 TASK: ffff880126762aa0 COMMAND: "sh" > [120] PID: 14736 TASK: ffff88010626e040 COMMAND: "sh" > > crash> This seems more clear. Thanks. > > Are you planning any further changes, or would you like to go with this > version for crash-6.1.1? No more changes for runq -g currently. So I am happy with the patch accepted. And once I said in the mail that I will change the rt_rq display by runq with no argument non-hierarchically and remove the group info in it. So I made the patch. And the patch is based on the two patches for runq -g.